[Bugfix] Fix pdl related intrin handling to avoid strict annotation codegen#1650
[Bugfix] Fix pdl related intrin handling to avoid strict annotation codegen#1650LeiWang1999 merged 1 commit intotile-ai:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe changes refactor PDL operator detection in the compiler from string-based matching to direct operator comparisons using Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
In future I think we can merge those into a general attribute to enable the restrct related codegen. |
This pull request updates the handling of CUDA synchronization and trigger calls in the PDL lowering and warp specialization code, and updates the TVM submodule. The changes simplify and clarify how these synchronization points are detected and marked in the codebase.
Refactoring of CUDA Sync/Trigger Call Detection:
MarkCudaSyncCallsinlower_pdl.ccto directly check fortl::pdl_trigger()andtl::pdl_sync()instead of matching external call names, improving robustness and maintainability.WarpSpecializedRoleMarkerinwarp_specialized_rewriter.ccto directly check forpdl_sync()andpdl_trigger()instead of string-based matching, ensuring more reliable role assignment.Testing Improvements:
test_pdl_synctest intest_tilelang_language_pdl.pyto assert that"__restrict__"is not present in the generated code, in addition to checking for"cudaGridDependencySynchronize".Dependency Update:
Summary by CodeRabbit
Release Notes
Improvements
Tests
✏️ Tip: You can customize this high-level summary in your review settings.